Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image pattern for FedoraSecondary provider on s390x #6082

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

harvey0100
Copy link
Contributor

Updated the image pattern in FedoraSecondaryImageProvider to match the available Fedora image file names for the s390x architecture. This resolves the issue where the vmimage utility could not download the correct image due to a pattern mismatch.

Reference: #6071

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.66%. Comparing base (b80f298) to head (3aff299).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
avocado/utils/vmimage.py 55.55% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6082       +/-   ##
===========================================
+ Coverage   54.32%   68.66%   +14.33%     
===========================================
  Files         202      202               
  Lines       21892    21899        +7     
===========================================
+ Hits        11892    15036     +3144     
+ Misses      10000     6863     -3137     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harvey0100 harvey0100 force-pushed the vmimage branch 2 times, most recently from 792b6f2 to d0fabf4 Compare December 11, 2024 14:09
Copy link
Contributor

@clebergnu clebergnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @harvey0100, this does seem to address the issue at hand, but I spotted a few blockers. Thanks for working on this!

avocado/utils/vmimage.py Outdated Show resolved Hide resolved
avocado/utils/vmimage.py Outdated Show resolved Hide resolved
avocado/utils/vmimage.py Outdated Show resolved Hide resolved
avocado/utils/vmimage.py Outdated Show resolved Hide resolved
@harvey0100 harvey0100 force-pushed the vmimage branch 8 times, most recently from 3aff299 to f5209e7 Compare December 16, 2024 14:59
Updated the image pattern in FedoraSecondaryImageProvider to match
the available Fedora image file names for the s390x architecture.
This resolves the issue where the vmimage utility could not download
the correct image due to a pattern mismatch.

Reference: avocado-framework#6071
Signed-off-by: Harvey Lynden <hlynden@redhat.com>
Copy link
Contributor

@clebergnu clebergnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@clebergnu clebergnu merged commit d91c081 into avocado-framework:master Dec 18, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 109
Development

Successfully merging this pull request may close these issues.

2 participants