Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collection of improvements #368

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

whizkid79
Copy link

  • add possibility to have category image overwritten during import using setAllowRenameFiles
  • fix for empty smart categories beeing added

collection of fixes from other PRs:

  • fix sorting options and defaults in categories
  • using enterprise import

Peter Halassek added 2 commits December 21, 2016 16:55
fix sorting options and defaults in categories, fix for empty smart categories beeing added, using enterprise import
@avstudnitz
Copy link
Owner

Thanks, but sorry: we can't let the module depend on Enterprise_ImportExport.
In any case, I'd prefer seperate pull requests for seperate issues - combining already existing PRs makes it more difficult to merge.

@whizkid79
Copy link
Author

i you don't stack the PR so high, we don't need to combine them to get a working version.
Looks like you do a bit of cleanup. let me know, when you are done, i can separate the different topics.

the issue with depend on Enterprise needs some solution thou, maybe a mockup for CE to fall back on the CE modules...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants