Initial draft adding advanced grouping and filtering #1
Conversation
Signed-off-by: Andre Wanlin <[email protected]>
awanlin
left a comment
awanlin
left a comment
There was a problem hiding this comment.
Left comments on the parts I could use some help with
| <m.InternalRouter formFieldLoaders={formFieldLoaders} />, | ||
| <m.InternalRouter | ||
| formFieldLoaders={formFieldLoaders} | ||
| groups={config.groups} |
There was a problem hiding this comment.
How do I translate an EntityPredicate to (entity: TemplateEntityV1beta3) => boolean?
There was a problem hiding this comment.
entityPredicateToFilterFunction from @backstage/plugin-catalog-react/alpha 😁
| defaultPath: '/docs', | ||
| loader: () => | ||
| import('../home/components/TechDocsCustomHome').then(m => | ||
| compatWrapper(<m.TechDocsCustomHome tabsConfig={config.tabs} />), |
There was a problem hiding this comment.
I think doing an if somewhere here where we check for config.tabs, if it's provided we use TechDocsCustomHome otherwise we use TechDocsIndexPage. I'm just not sure where that would go.
Also have some type issues here like getting it to be happy with the PanelType and the filterPredicate
There was a problem hiding this comment.
Yep something like that sounds good, might be best to push some WIP code here to have something to look at
| panelType: 'InfoCardGrid' | ||
| filter: | ||
| metadata.tags: | ||
| $in: ['golden-path'] |
There was a problem hiding this comment.
This is the end goal I'm trying to make work. I want to use the filtering that was introduced here: backstage#28951
Hey, I just made a Pull Request!
✔️ Checklist
Signed-off-byline in the message. (more info)