Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add minimal layout method #130

Open
wants to merge 2 commits into
base: 3.x
Choose a base branch
from

Conversation

gladjanus43
Copy link

This method adds the possibility for users to choose the minimal layout. This method removes rings, borders, background and divides. Leaving only the Inputs, headers and actions in a minimal way.

This method adds the possibility for users to choose the minimal layout. This method removes rings, borders, background and divides. Leaving only the Inputs, headers and actions in a minimal way.
@gladjanus43
Copy link
Author

This is my first contribution so I hope I did everything right. If not please let me know!

@awcodes
Copy link
Owner

awcodes commented Oct 28, 2024

Can you give me a screenshot showing the differences?

@gladjanus43
Copy link
Author

gladjanus43 commented Oct 29, 2024

The regular tablerepeater:
Screenshot 2024-10-29 at 11 35 27

The minimal table repeater:
Screenshot 2024-10-29 at 11 40 51

@awcodes
Copy link
Owner

awcodes commented Oct 29, 2024

Thanks, I'll review the code as soon as I can.

@awcodes
Copy link
Owner

awcodes commented Nov 1, 2024

I think you're missing some of the styles, make sure you have included the views and the stylesheet in a custom theme according to the installation setups in the readme.

This is what I'm currently seeing with your PR. If you can resolve this I'll merge it in.

Also think the mobile looks weird without the borders, can you make it so the styling is only applied when it's in the 'table' view?

Screenshot 2024-11-01 at 10 31 31 AM

Screenshot 2024-11-01 at 10 31 42 AM

@gladjanus43
Copy link
Author

Will add the styles when I have the time! Also for the borders on mobile, since it is minimal maybe we just add a border between two rows? And not the entire border around?

@awcodes
Copy link
Owner

awcodes commented Nov 7, 2024

I still think on mobile with an overall border is better from a uX / ui standpoint. Without the "card appearance" the paddings look like a mistake.

agusesetiyono added a commit to agusesetiyono/filament-table-repeater that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants