-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add minimal layout method #130
base: 3.x
Are you sure you want to change the base?
Conversation
This method adds the possibility for users to choose the minimal layout. This method removes rings, borders, background and divides. Leaving only the Inputs, headers and actions in a minimal way.
This is my first contribution so I hope I did everything right. If not please let me know! |
Can you give me a screenshot showing the differences? |
Thanks, I'll review the code as soon as I can. |
I think you're missing some of the styles, make sure you have included the views and the stylesheet in a custom theme according to the installation setups in the readme. This is what I'm currently seeing with your PR. If you can resolve this I'll merge it in. Also think the mobile looks weird without the borders, can you make it so the styling is only applied when it's in the 'table' view? |
Will add the styles when I have the time! Also for the borders on mobile, since it is minimal maybe we just add a border between two rows? And not the entire border around? |
I still think on mobile with an overall border is better from a uX / ui standpoint. Without the "card appearance" the paddings look like a mistake. |
This method adds the possibility for users to choose the minimal layout. This method removes rings, borders, background and divides. Leaving only the Inputs, headers and actions in a minimal way.