Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the C coverage to the CodeCov GitHub Action #3947

Merged
merged 6 commits into from
Oct 26, 2024
Merged

Conversation

Elv13
Copy link
Member

@Elv13 Elv13 commented Aug 25, 2024

Same as Last PR. Now I expect the Lua coverage to work and the C coverage. I did it in 2 PRs to make sure the delta works.

I also added a -j16 in the example test step because it is I/O bound and it has enough ram. This should speed-up the CI (maybe?).

Fix #3934

Same as Last PR. Now I expect the Lua coverage to work and the C coverage. I did it in 2 PRs to make sure the delta works.

I also added a `-j8` in the example test step because it is I/O bound and it has enough ram. This should speed-up the CI (maybe?).
@awesome-robot
Copy link

Documentation has been updated for this PR.

Compare view: awesomeWM/apidoc@adf4661...31233a7
Relevant changes: awesomeWM/apidoc@5bc322a
Comparison against master (gh-pages): awesomeWM/apidoc@gh-pages...31233a7

awesome-robot added a commit to awesomeWM/apidoc that referenced this pull request Aug 25, 2024
Last commit message:
Merge 525db87185d68e722c32658f0bf045bae927ead5 into 7034db3a446d61327305f5fef7d4d908804724a3

Commits:
Build URL: https://github.com/awesomeWM/awesome/actions/runs/10548445802
Pull request: awesomeWM/awesome#3947
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.52%. Comparing base (7034db3) to head (8ef35f5).
Report is 17 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (7034db3) and HEAD (8ef35f5). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (7034db3) HEAD (8ef35f5)
gcov 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3947       +/-   ##
===========================================
- Coverage   91.26%   48.52%   -42.74%     
===========================================
  Files         936      195      -741     
  Lines       60147    22424    -37723     
===========================================
- Hits        54894    10882    -44012     
- Misses       5253    11542     +6289     
Flag Coverage Δ
gcov ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 884 files with indirect coverage changes

@awesome-robot
Copy link

Documentation has been updated for this PR.

Compare view: awesomeWM/apidoc@adf4661...fcf11ac
Relevant changes: awesomeWM/apidoc@a7aa9c7
Comparison against master (gh-pages): awesomeWM/apidoc@gh-pages...fcf11ac

@awesome-robot
Copy link

Documentation has been updated for this PR.

Compare view: awesomeWM/apidoc@adf4661...bf094e6
Relevant changes: awesomeWM/apidoc@c96525b
Comparison against master (gh-pages): awesomeWM/apidoc@gh-pages...bf094e6

@@ -308,7 +304,7 @@ jobs:
run: cd "${{ github.workspace }}/build" && make check-unit

- name: Run examples tests
run: cd "${{ github.workspace }}/build" && make check-examples
run: cd "${{ github.workspace }}/build" && make check-examples -j16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be -j$(nproc) ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the examples tests are not CPU bound, they are I/O bound. For example, I use -j99 on my 16 thread desktop and it's 4x faster than -j17. As long as it doesn't take more ram than the VM has, the larger the number is, the faster it goes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment with this explanation?

@awesome-robot
Copy link

Documentation has been updated for this PR.

Compare view: awesomeWM/apidoc@bfbd86f...c77af50
Relevant changes: awesomeWM/apidoc@2ae4bd6
Comparison against master (gh-pages): awesomeWM/apidoc@gh-pages...c77af50

@awesome-robot
Copy link

Documentation has been updated for this PR.

Compare view: awesomeWM/apidoc@bfbd86f...e5b8bb6
Relevant changes: awesomeWM/apidoc@9880912
Comparison against master (gh-pages): awesomeWM/apidoc@gh-pages...e5b8bb6

@awesome-robot
Copy link

Documentation has been updated for this PR.

Compare view: awesomeWM/apidoc@bfbd86f...6d344c1
Relevant changes: awesomeWM/apidoc@840665f
Comparison against master (gh-pages): awesomeWM/apidoc@gh-pages...6d344c1

@mergify mergify bot merged commit 2b7006f into master Oct 26, 2024
10 of 11 checks passed
@mergify mergify bot deleted the fix-coverage2 branch October 26, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codecov pipeline not responding in PRs
4 participants