Add a rect shape with corners having different radii

[aidinio]

Added a shape that can have a different radius on each corner.

[codecov]

Codecov Report

❌ Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.40%. Comparing base (9475bb9) to head (73e98f4).
⚠️ Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
lib/gears/shape.lua	71.42%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3991      +/-   ##
==========================================
- Coverage   90.41%   90.40%   -0.01%     
==========================================
  Files         938      939       +1     
  Lines       60232    60260      +28     
  Branches     1139     1139              
==========================================
+ Hits        54457    54478      +21     
- Misses       5269     5276       +7     
  Partials      506      506              

Files with missing lines	Coverage Δ
...examples/gears/shape/individually_rounded_rect.lua	100.00% <100.00%> (ø)
lib/gears/shape.lua	96.47% <71.42%> (-1.40%)	⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[aidinio]

I'm not sure why the test failed.

[sclu1034]

I'm not sure why the test failed.

Codecov fails because none of your lines are covered by tests and you end up below the target. That's another thing documentation examples are used for: they also feed into the testing framework.

[aidinio]

I'm not sure why the test failed.

Codecov fails because none of your lines are covered by tests and you end up below the target. That's another thing documentation examples are used for: they also feed into the testing framework.

Thanks for the help. I also added tests.

[aidinio]

@Aire-One Hi! Aren't there any other reviewers to approve my PR?

[Aire-One]

Hi @aidinio, sadly most other maintainers are AWOL for some time now... Let's try to ping @awesomeWM/write-access

[actionless]

but coverage is not enough: #3991 (comment)

[aidinio]

but coverage is not enough: #3991 (comment)

I've already added tests which resolve the coverage issue.

[actionless]

yeah, codecov stuck on previous commit: https://app.codecov.io/gh/awesomeWM/awesome/pull/3991/commits

[aidinio]

yeah, codecov stuck on previous commit: https://app.codecov.io/gh/awesomeWM/awesome/pull/3991/commits

Can I somehow restart the codecov check? It's stuck on "Waiting for status to be reported".

[actionless]

no, as CI currently broken: #3994

[actionless]

now it's finally fixed, so you could rebase 👌😸

[aidinio]

now it's finally fixed, so you could rebase 👌😸

Thanks!

[Aire-One]

@Mergifyio rebase

[mergify]

rebase

✅ Branch has been successfully rebased

[actionless]

it seems example is not being imported correctly: https://app.codecov.io/github/awesomeWM/awesome/commit/007e444a525ff9a90b015341a9ea0fe216ae5dd4

can you see it in generated docs?

[Aire-One]

Yeah, I had the same feeling. #4043 should fix the coverage!

[actionless]

thanks @Aire-One ! now the coverage report shows it correctly which more tests @aidinio would need to add