Show names of who voted for projects on finalist page. #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| names = ""; | ||
| users.each_with_index do |user, index| | ||
| names << user.name | ||
| if index != users.size - 1 |
There was a problem hiding this comment.
I think I'd prefer an array of names here, and then we can render it as arr.join(", ") in the view.
|
I would suggest that we not display the voter names by default - I can imaging that lots of chapters would want this to be anonymous. Instead we should hide them all and then display them with a "show voters" button. |
| </tr> | ||
| <% @projects.each do |project| %> | ||
| <tr class="finalist" data-count="<%= project.vote_count %>" data-id="<%= project.id %>"> | ||
| <td><%= link_to project.title, chapter_project_path(project.chapter, project) %></td> | ||
| <td><%= project.id %></td> | ||
| <td><%= project.vote_count %></td> | ||
| <td><%= project.vote_names %></td> |
There was a problem hiding this comment.
This is going to get super heavy on a page with a lot of projects, so we probably want to do some eager loading on the page that loads the projects.
|
I like the idea of this, so can chase up specific people who haven't voted yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.