Skip to content

Wrap "No downloadable files found" in filter called edd_receipt_no_files_found_text #7486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mintplugins opened this issue Dec 3, 2019 · 6 comments · May be fixed by #7517
Open

Wrap "No downloadable files found" in filter called edd_receipt_no_files_found_text #7486

mintplugins opened this issue Dec 3, 2019 · 6 comments · May be fixed by #7517
Labels
type-bug workflow-has-pr workflow-needs-lead-feedback workflow-needs-testing

Comments

@mintplugins
Copy link
Contributor

Bug Report

Expected behavior

When I use the Downloads as Services add-on and make a product a "Service", I expect the message "No downloadable files found" to be not shown in the [download_history] shortcode.

Actual behavior

The message is shown in the [download_history] shortcode.

Steps to reproduce the behavior

  1. Install Downloads as Services.
  2. Make a product a "Service".
  3. Purchase the product.
  4. View a page with the [download_history] shortcode and navigate to the files view.
  5. Notice the message is still shown.

This happens because the filter is missing here:
https://github.com/easydigitaldownloads/easy-digital-downloads/blob/b2ce5ed02d62737dd17ac665a71a493d9efe5898/templates/history-downloads.php#L74

In other places, it is wrapped in a filter called edd_receipt_no_files_found_text:
https://github.com/easydigitaldownloads/easy-digital-downloads/blob/b3b09b718d04ded5611b8b34194cbb77190a2c47/templates/shortcode-receipt.php#L207
https://github.com/easydigitaldownloads/easy-digital-downloads/blob/dc24a2a8a325dc87000ba4492cd0e5dc2006740c/includes/emails/class-edd-email-tags.php#L466

A filter should also be added for bundled items here:
https://github.com/easydigitaldownloads/easy-digital-downloads/blob/b3b09b718d04ded5611b8b34194cbb77190a2c47/templates/shortcode-receipt.php#L198

Information (if a specific version is affected):

EDD Version (or branch): master
@Jo-IE
Copy link

Jo-IE commented Jan 14, 2020

Hi! I applied for the recent Developer opening at Sandhills Development and I am very interested in getting more familiar with the codebase. Could I have a go at this issue?

Thanks!

@cklosowski
Copy link
Contributor

@Jo-IE By all means, if you want to give it a go, you are more than welcome. We appreciate all contributions to EDD.

@cklosowski
Copy link
Contributor

@Jo-IE If you haven't already, check out our Contributing guidelines here: https://github.com/easydigitaldownloads/easy-digital-downloads/blob/master/CONTRIBUTING.md#making-changes

@Jo-IE
Copy link

Jo-IE commented Jan 17, 2020

thank you @cklosowski !

Also a quick question: How do I view the changes to the add-on? I already have a local environment set up for wordpress/PHP and I am able to add the plugin to a demo site. Do I need to have a demo site set up with products? Thank you in advance!

@cklosowski
Copy link
Contributor

Hey @Jo-IE The easiest way is to clone this repository into the wp-content/plugins folder. Once you have it cloned locally, you should be able to enable the plugin within the WordPress admin panel (/wp-admin).

From there, creating a product can be done in Downloads > Add New.

@Jo-IE
Copy link

Jo-IE commented Jan 17, 2020

Thanks again @cklosowski , that sounds a lot easier!

Jo-IE added a commit to Jo-IE/easy-digital-downloads that referenced this issue Jan 18, 2020
@Jo-IE
Remove no downloadable files message when product is service awesomem…
2993be3 
…otive#7486
@Jo-IE Jo-IE linked a pull request Jan 18, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug workflow-has-pr workflow-needs-lead-feedback workflow-needs-testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove no downloadable files message when product is service #7486 Jo-IE/easy-digital-downloads
4 participants
@pippinsplugins @cklosowski @mintplugins @Jo-IE