Remove no downloadable files message when product is service #7486 #7517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mintplugins
reviewed
Jan 20, 2020
templates/history-downloads.php
Outdated
| @@ -71,7 +71,7 @@ | |||
| endforeach; | |||
|
|
|||
| else : | |||
| _e( 'No downloadable files found.', 'easy-digital-downloads' ); | |||
| apply_filters('edd_receipt_no_files_found_text', __( 'No downloadable files found.', 'easy-digital-downloads' ), $download['id']); | |||
There was a problem hiding this comment.
@Jo-IE It looks like this won't get output to the screen because the _e function has been removed. You'll need to replace it with an echo command so that it gets output to the screen once the filter has been applied.
There was a problem hiding this comment.
ok, I see. I will get on it right away. Thank you @mintplugins !
|
I'm not sure if the build is failing because of my PR but I see some tests failing. Do I need to rectify those? |
|
@Jo-IE Don't worry about those. Those failures are due to a change in WordPress core that we just need to write some conditions for. The failures are not for your fix and you don't need to rectify those at this time. |
|
ok, thank you @cklosowski |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7486
Used the
edd_receipt_no_files_found_textfunction to wrap theNo downloadable filestext.Fix works locally, text no longer shows up for products that are services.