Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue/5660 - Add support for download category in permalinks #6309

Open
wants to merge 3 commits into
base: release/3.0
Choose a base branch
from
Open

issue/5660 - Add support for download category in permalinks #6309

wants to merge 3 commits into from

Conversation

sunnyratilal
Copy link
Contributor

@sunnyratilal sunnyratilal commented Jan 14, 2018 •
edited by pippinsplugins
Loading

Resolves #5660.

@sunnyratilal sunnyratilal mentioned this pull request Jan 14, 2018
Open
pippinsplugins
pippinsplugins suggested changes Jan 15, 2018
View reviewed changes
includes/post-types.php Outdated
return $permalink;
}

$should_modify_permalink = apply_filters( 'edd_should_change_post_link', __return_false() );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's simplify this __return_false() to just false.

@sunnyratilal
Copy link
Contributor Author

PR updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pippinsplugins pippinsplugins pippinsplugins requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunnyratilal @pippinsplugins