Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore ability to use web-identity-token-file (issue: #124) #759

Closed
wants to merge 1 commit into from

Conversation

stephenc
Copy link

Issue #124

Description of changes:

The validation logic for credentials was failing for the web-identity-token-file use case which needs to be handled similarly to the OIDC case as I understand it


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@peterwoodworth peterwoodworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, and makes sense. I need to set this up so I can actually properly test this before approving, will get to that next week.

@stephenc
Copy link
Author

stephenc commented Jul 1, 2023

I'm just driving by. Feel free to do what you want with this. It's not blocking me as we have OIDC set up and working... I was just trying to understand what goes on underneath the covers 🤣

@peterwoodworth
Copy link
Contributor

Yeah I think you're right, I still just need to test it. This week was busier than expected for me, but I should be able to try next week

@Udbv
Copy link

Udbv commented Jul 24, 2023

I spend several hours to understand why web-identity-token-file throw error and none created an issue :-)

@stephenc
Copy link
Author

@Udbv feel free to try uses: stephenc/configure-aws-credentials@1b2bf9cf72eda1d55257a2d29cb418fb30410136 as I suspect that will solve your issue ;-)

@peterwoodworth
Copy link
Contributor

@stephenc I didn't have the capacity approve this while we were getting internal approvals for v3, but thank you for the contribution to help me kick off this fix in v3. I really appreciate it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants