Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove validation requiring idc arn for Application create #55

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Remove validation requiring idc arn for Application create #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions ...qbusiness-application/src/main/java/software/amazon/qbusiness/application/Translator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
import software.amazon.awssdk.services.qbusiness.model.TagResourceRequest;
import software.amazon.awssdk.services.qbusiness.model.UntagResourceRequest;
import software.amazon.awssdk.services.qbusiness.model.UpdateApplicationRequest;
import software.amazon.cloudformation.exceptions.CfnInvalidRequestException;
import software.amazon.cloudformation.proxy.ResourceHandlerRequest;

/**
Expand All @@ -37,10 +36,6 @@ public class Translator {
* @return awsRequest the aws service request to create a resource
*/
static CreateApplicationRequest translateToCreateRequest(final String idempotentToken, final ResourceModel model) {
// https://w.amazon.com/bin/view/AWS21/Design/Uluru/Onboarding_Guide/ModelingGuidelines#HRequiredWriteOnlyProperties
if (model.getIdentityCenterInstanceArn() == null) {
throw new CfnInvalidRequestException("IdentityCenterInstanceArn is required.");
}
return CreateApplicationRequest.builder()
.clientToken(idempotentToken)
.displayName(model.getDisplayName())
Expand Down