fix(DBCluster): Handle delete handler stabilization when dbcluster listempty #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angusy29
commented
Sep 3, 2024
| @@ -401,7 +401,7 @@ protected boolean isDBClusterDeleted( | |||
| ) { | |||
| try { | |||
| fetchDBCluster(proxyClient, model); | |||
| } catch (DbClusterNotFoundException e) { | |||
| } catch (DbClusterNotFoundException | IndexOutOfBoundsException e) { | |||
There was a problem hiding this comment.
I thought about making this catch at fetchDBCluster (further up the call stack), but isDBClusterDeleted is only called in 1 callsite and contains the blast radius to just the DeleteHandler.
ccmlst
previously approved these changes
Sep 4, 2024
…ist is empty in describe
angusy29
force-pushed
the
delete-handler
branch
from
e11a043
to
5e73503
Compare
zrfr
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
When a user deletes their DBCluster, the DBCluster is first deleted via DeleteDbCluster.
The handler then runs stabilization, where it calls describeDbCluster.
When the describeDbCluster occurs right after DeleteDbCluster, the DescibeDbCluster call can return an empty DbClusters list instead of a DBClusterNotFoundException, and this causes the DeleteHandler to fail.
If the user re-attempts a stack deletion, the second try of stack deletion will succeed, because the DescribeDbCluster call will throw a DBClusterNotFoundException.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.