add global cluster endpoint to rds-globalcluster #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccmlst
reviewed
Jan 15, 2025
| "description": " The storage encryption setting for the new global database cluster.\nIf you specify the SourceDBClusterIdentifier property, don't specify this property. The value is inherited from the cluster.", | ||
| "type": "boolean" | ||
| }, | ||
| "GlobalEndpoint": { |
There was a problem hiding this comment.
not passed in as part of the createGlobalCluster request, it is created with the global cluster
There was a problem hiding this comment.
It seems to me we need to add it as a readonly property (similar to e.g. https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-rds/blob/master/aws-rds-dbcluster/aws-rds-dbcluster.json#L436) - see https://docs.aws.amazon.com/cloudformation-cli/latest/userguide/resource-type-schema.html
readOnlyProperties
Resource properties that can be returned by a read or list request, but can't be set by the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Following up with the launch of global cluster endpoints https://aws.amazon.com/about-aws/whats-new/2024/10/amazon-aurora-global-database-writer-endpoint, adding global cluster endpoints to rds-global-cluster
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.