Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule E3505 to validate lambda,sqs timeouts #3990

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Mar 5, 2025

Issue #, if available:
fix #3987

Description of changes:

  • Add rule E3505 to validate lambda,sqs timeouts

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 95.34884% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.90%. Comparing base (7fee6bd) to head (9f89d1a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...s/resources/lmbd/EventSourceMappingToSqsTimeout.py 95.34% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3990      +/-   ##
==========================================
- Coverage   93.90%   93.90%   -0.01%     
==========================================
  Files         376      377       +1     
  Lines       13000    13043      +43     
  Branches     2555     2567      +12     
==========================================
+ Hits        12208    12248      +40     
- Misses        438      439       +1     
- Partials      354      356       +2     
Flag Coverage Δ
unittests 93.88% <95.34%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kddejong kddejong merged commit ef15a85 into aws-cloudformation:main Mar 5, 2025
21 checks passed
@kddejong kddejong deleted the fix/issue/3987 branch March 5, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identify incorrect MessageVisibilityTimeout using EventSourceMapping
1 participant