refactor: convert runtime tests from external to internal package tests #202
Conversation
|
/retest |
1 similar comment
|
/retest |
|
/test ec2-controller-test |
|
/retest |
|
/test ec2-controller-test |
|
/retest |
1 similar comment
|
/retest |
|
/test ec2-controller-test |
Change test files from `runtime_test` to `runtime` package to enable testing of package private functions. Remove ackrt import alias as tests now have direct access to runtime package symbols.
michaelhtm
force-pushed
the
runtime/unit-rework
branch
from
7624d0d to
fb7fe0a
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/test ecr-controller-test |
|
/test iam-controller-test |
|
@a-hilaly: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test iam-controller-test |
2 participants
Change test files from
runtime_testtoruntimepackage to enabletesting of package private functions. Remove ackrt import alias
as tests now have direct access to runtime package symbols.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.