Fix initial termination starting point, behavior on curves#32
Merged
Conversation
…ermination rounding on curves
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
terminate!withinitial=truewas written to append the termination before the path, but becausepa.p0was not being updated, it was being reconciled such that the rest of thePathwas shifted forward. This bug did not affect usage as long as relative positioning (e.g., relative top0(pa)or hooks) was used.terminate!on a curve with rounding would previously eat some of the turn angle then go straight by the rounding length plus termination gap. This caused the final direction to change (or caused the entire path to rotate slightly wheninitial=true). Now it finishes out the underlying curve and only goes straight by the termination gap afterward, keeping the final direction the same. (This is the second item in New Path styles #22.) The termination is still drawn as though straight, allowing rounding to be represented with exact circular arcs.