Improve single transmon example #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpeairs
force-pushed
the
gp/singletransmon
branch
from
e098d98 to
c2e7fb6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
|
Documentation preview is live here (until this is merged). |
hughcars
reviewed
Mar 14, 2025
| qubit_node = add_node!(g, qubit) | ||
| rres_node = fuse!(g, qubit_node, rres) | ||
| # Equivalent to `fuse!(g, qubit_node=>:readout, rres=>:qubit)` | ||
| # because `matching_hooks` was implemented for that component pai |
| @@ -120,8 +137,11 @@ function single_transmon(; | |||
| chip = centered(Rectangle(substrate_x, substrate_y), on_pt=center_xyz) | |||
| sim_area = centered(Rectangle(substrate_x, substrate_y), on_pt=center_xyz) | |||
|
|
|||
| # Define bounds for bound simulation box | |||
Comment on lines
138
to
139
| # This component creates narrow regions defined by the gap between it and others | ||
| # For now we should explicitly set mesh sizing since meshing doesn't use proximity |
There was a problem hiding this comment.
Maybe drop the "for now" as supporting proximity would be complicated, so we don't want to give the impression we'll definitely be doing it at some point.
hughcars
reviewed
Mar 14, 2025
|
|
||
| - `solver_order = 2`: Finite element order (degree) for the solver. Palace supports arbitrary | ||
| high-order spaces. | ||
| - `mesh_order = 2`: Element order for the mesh. |
There was a problem hiding this comment.
Maybe polynomial order used to represent the element geometries in the mesh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a demo using the CAD + simulation pipeline to run closed loop optimization. To do this, I had to add mesh sizing to the transmon and resonator components to ensure mesh/solver order 2 was enough to get optimization to converge to target frequencies within 1% without any refinement. Also cleaned up the text and code a bit.