chore: Revert "chore: temporary pin virtualenv<21 to fix build (#206)"#211
Closed
jericht wants to merge 1 commit intoaws-deadline:mainlinefrom
Closed
chore: Revert "chore: temporary pin virtualenv<21 to fix build (#206)"#211jericht wants to merge 1 commit intoaws-deadline:mainlinefrom
jericht wants to merge 1 commit intoaws-deadline:mainlinefrom
Conversation
github-actions
bot
added
the
waiting-on-maintainers
jericht
changed the title
leongdl
approved these changes
Mar 11, 2026
seant-aws
approved these changes
Mar 12, 2026
AlexTranAmz
approved these changes
Mar 12, 2026
…eadline#206)" Signed-off-by: Jericho Tolentino <68654047+jericht@users.noreply.github.com>
jericht
force-pushed
the
jericht/revert_fix_build
branch
from
47c38e0 to
65ee3bf
Compare
|
godobyte
approved these changes
Mar 12, 2026
epmog
requested changes
Mar 16, 2026
| - name: Install dependencies | ||
| run: | | ||
| pip install --upgrade hatch "click<8.3" "virtualenv<21" | ||
| pip install --upgrade hatch "click<8.3" |
Contributor
There was a problem hiding this comment.
won't work for this action since python 3.9 is specified, should prob just update the python version to something newer
| - name: Install dependencies | ||
| run: | | ||
| pip install --upgrade hatch "click<8.3" "virtualenv<21" | ||
| pip install --upgrade hatch "click<8.3" |
Contributor
|
Closing this PR as it's stale, the correct fix should be OpenJobDescription/openjd-sessions-for-python#305 |
auto-merge was automatically disabled
March 23, 2026 17:31
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The original commit temporarily pinned
virtualenv<21to fix a build issue. This workaround is no longer needed as the underlying issue has been fixed in hatch v1.16.5.What was the solution? (How)
Reverted the commit that added the
virtualenv<21pin across all workflow files and build scripts.What is the impact of this change?
Build and test workflows will now use the latest compatible version of
virtualenvinstead of being pinned to versions below 21.How was this change tested?
GitHub actions still succeed
Was this change documented?
N/A
Does this PR introduce new dependencies?
This library is designed to be integrated into third-party applications that have bespoke and customized deployment environments. Adding dependencies will increase the chance of library version conflicts and incompatabilities. Please evaluate the addition of new dependencies. See the Dependencies section of DEVELOPMENT.md for more details.
Is this a breaking change?
No
Does this change impact security?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.