chore: Compatibility fix to compensate for moving _hash_attachments into the Job Attachments code#868
Draft
evanspearman-a wants to merge 1 commit intoaws-deadline:mainlinefrom
Draft
Conversation
github-actions
bot
added
the
waiting-on-maintainers
…nto the Job Attachments code Signed-off-by: Evan Spearman <evans@amazon.com>
evanspearman-a
force-pushed
the
move_hash_attachments
branch
from
44fc2bc to
b887f94
Compare
|
leongdl
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This should be merged at the same time as updating to the version of deadline-cloud (
deadline) that releases this change: aws-deadline/deadline-cloud#966What was the problem/requirement? (What/Why)
The worker agent calls a non-public function (
_manifest_snapshot) in the client/job attachments code which had its signature changed as part of an effort to decouple job attachments and the rest of the client.What was the solution? (How)
Update calls to this function to use the new signature. This includes querying the config ourself to get the hash cache directory and providing a telemetry callback. Config querying and telemetry were previously done by a function called by the modified function, but are no longer as this is a library function and config and telemetry are application responsibilities.
What is the impact of this change?
This will be used to fix compatibility with the
deadlinepackage when it is updated.How was this change tested?
I ran the unit tests and e2e tests.
Was this change documented?
N/A
Is this a breaking change?
No.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.