[WIP] chore: update deadline verison with JA breaking changes#901
Open
AlexTranAmz wants to merge 2 commits intoaws-deadline:mainlinefrom
Open
[WIP] chore: update deadline verison with JA breaking changes#901AlexTranAmz wants to merge 2 commits intoaws-deadline:mainlinefrom
AlexTranAmz wants to merge 2 commits intoaws-deadline:mainlinefrom
Conversation
epmog
requested changes
Mar 27, 2026
leongdl
reviewed
Mar 27, 2026
Signed-off-by: Alex Tran <167144297+AlexTranAmz@users.noreply.github.com>
c0350a9 to
3670f30
Compare
|
epmog
reviewed
Mar 27, 2026
Comment on lines
+53
to
+54
| S3_MAX_POOL_CONNECTIONS = 50 | ||
| SMALL_FILE_THRESHOLD_MULTIPLIER = 20 |
Contributor
There was a problem hiding this comment.
So previously this would use deadline's config, though this is on a worker agent, so it probably wasn't set and would use the default. Is this something we should add a configuration option for? Can potentially punt for now, but it is worth thinking about.
Contributor
Author
There was a problem hiding this comment.
This is just deadline's config default, we decided to keep it as a enum here and we can revisit later if we need a config or not, it's a 2 ways door and I prefer not overcomplicated for now with just 2 values.
leongdl
approved these changes
Mar 27, 2026
Contributor
|
Unit tests failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This should not be merged until
deadline==0.55.0got release. The check with fail until thenWhat was the problem/requirement? (What/Why)
deadlinejust update to 0.55.0 with a JA breaking changes, and it break worker agentWhat was the solution? (How)
Update worker agent to work with new version of
deadlineWhat is the impact of this change?
WA can now consume the latest version of
deadlinewithout errorHow was this change tested?
Was this change documented?
Yes
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.