Skip to content

[WIP] chore: update deadline verison with JA breaking changes#901

Open
AlexTranAmz wants to merge 2 commits intoaws-deadline:mainlinefrom
AlexTranAmz:update-deadline-cloud
Open

[WIP] chore: update deadline verison with JA breaking changes#901
AlexTranAmz wants to merge 2 commits intoaws-deadline:mainlinefrom
AlexTranAmz:update-deadline-cloud

Conversation

@AlexTranAmz
Copy link
Copy Markdown
Contributor

This should not be merged until deadline == 0.55.0 got release. The check with fail until then

What was the problem/requirement? (What/Why)

deadline just update to 0.55.0 with a JA breaking changes, and it break worker agent

What was the solution? (How)

Update worker agent to work with new version of deadline

What is the impact of this change?

WA can now consume the latest version of deadline without error

How was this change tested?

  • Unit test
Required test coverage of 78.0% reached. Total coverage: 84.00%
================================================= slowest 5 durations ==================================================
1.01s call     test/unit/test_worker.py::TestMonitorEc2Shutdown::test_spot_interruption[spot-shutdown-15-sec]
1.01s call     test/unit/test_worker.py::TestMonitorEc2Shutdown::test_asg_termination
1.01s call     test/unit/test_worker.py::TestMonitorEc2Shutdown::test_spot_interruption[spot-shutdown-1-min]
0.80s call     test/unit/test_copyright_header.py::test_copyright_headers
0.79s call     test/unit/sessions/actions/scripts/test_attachment_upload.py::TestAttachmentUpload::test_main_with_output
==================================== 2683 passed, 41 skipped, 24 warnings in 21.58s ====================================
  • Windows E2E tests
============================= slowest 5 durations ==============================
704.21s call     test/e2e/test_worker_config.py::TestWorkerConfiguration::test_worker_shuts_down_host_machine_if_configured
425.55s call     test/e2e/test_worker_config.py::TestWorkerConfiguration::test_worker_local_session_logs_can_be_turned_off
420.47s call     test/e2e/test_worker_config.py::TestWorkerConfiguration::test_worker_requires_no_instance_profile
379.02s setup    test/e2e/test_override_job_user.py::TestWindowsJobUserOverride::test_no_user_override
369.24s setup    test/e2e/test_job_attachments.py::TestJobAttachments::test_worker_job_attachment_storage_profile_path_mapping[linux]
============ 47 passed, 17 skipped, 1 warning in 6441.81s (1:47:21) ============
  • Linux E2E tests
============================= slowest 5 durations ==============================
610.58s call     test/e2e/test_worker_config.py::TestWorkerConfiguration::test_worker_shuts_down_host_machine_if_configured
278.85s setup    test/e2e/test_worker_status.py::TestWorkerStatus::test_linux_worker_restarts_process
256.36s call     test/e2e/test_worker_config.py::TestWorkerConfiguration::test_worker_requires_no_instance_profile
229.36s setup    test/e2e/test_job_submissions.py::TestJobSubmission::test_worker_enters_stopping_state_while_draining
210.33s call     test/e2e/test_worker_config.py::TestWorkerConfiguration::test_session_root_dir
============ 49 passed, 15 skipped, 1 warning in 4404.24s (1:13:24) ============

Was this change documented?

Yes

Is this a breaking change?

No


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AlexTranAmz AlexTranAmz requested a review from a team as a code owner March 27, 2026 21:25
@github-actions github-actions bot added the waiting-on-maintainers Waiting on the maintainers to review. label Mar 27, 2026
Signed-off-by: Alex Tran <167144297+AlexTranAmz@users.noreply.github.com>
@AlexTranAmz AlexTranAmz force-pushed the update-deadline-cloud branch from c0350a9 to 3670f30 Compare March 27, 2026 21:54
@sonarqubecloud
Copy link
Copy Markdown

Comment on lines +53 to +54
S3_MAX_POOL_CONNECTIONS = 50
SMALL_FILE_THRESHOLD_MULTIPLIER = 20
Copy link
Copy Markdown
Contributor

@epmog epmog Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So previously this would use deadline's config, though this is on a worker agent, so it probably wasn't set and would use the default. Is this something we should add a configuration option for? Can potentially punt for now, but it is worth thinking about.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just deadline's config default, we decided to keep it as a enum here and we can revisit later if we need a config or not, it's a 2 ways door and I prefer not overcomplicated for now with just 2 values.

@leongdl
Copy link
Copy Markdown
Contributor

leongdl commented Mar 27, 2026

Unit tests failed

@AlexTranAmz AlexTranAmz removed the waiting-on-maintainers Waiting on the maintainers to review. label Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants