ALS-1805 [iOS] Remove amplify dependency from the demo app #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Als 1805 remove amplify
Als-1805 Final Remove amplify commit with test case fixes
Als 1805 remove amplify
Update LocationServices.xctestplan
mbalfour-amzn
requested changes
Oct 10, 2024
...ervices/LocationServices.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Outdated
Show resolved
Hide resolved
LocationServices/LocationServices/Extensions/AWSEndpoint+Extension.swift
Outdated
Show resolved
Hide resolved
LocationServices/LocationServices/Extensions/Double+Extension.swift
Outdated
Show resolved
Hide resolved
LocationServices/LocationServices/Extensions/Double+Extension.swift
Outdated
Show resolved
Hide resolved
LocationServices/LocationServices/Extensions/Double+Extension.swift
Outdated
Show resolved
Hide resolved
LocationServices/LocationServicesTests/SearchViewModelTests.swift
Outdated
Show resolved
Hide resolved
LocationServices/LocationServicesTests/TrackingViewModelTests.swift
Outdated
Show resolved
Hide resolved
LocationServices/LocationServicesTests/TrackingViewModelTests.swift
Outdated
Show resolved
Hide resolved
LocationServices/LocationServicesTests/TrackingViewModelTests.swift
Outdated
Show resolved
Hide resolved
ALS-1805 fixed PR feedback
LocationServices/LocationServices/Extensions/Double+Extension.swift
Outdated
Show resolved
Hide resolved
LocationServices/LocationServices/Extensions/Int+Extension.swift
Outdated
Show resolved
Hide resolved
LocationServices/LocationServices/Extensions/Int+Extension.swift
Outdated
Show resolved
Hide resolved
mbalfour-amzn
approved these changes
Oct 15, 2024
cgalvan
reviewed
Oct 15, 2024
...ervices/LocationServices.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Show resolved
Hide resolved
| Task { | ||
| guard let lat = userLocation?.coordinate.latitude, | ||
| let long = userLocation?.coordinate.longitude else { return } | ||
| try await GeofenceAPIService().evaluateGeofence(lat: lat, long: long) |
There was a problem hiding this comment.
Nit: It looks like this line isn't indented the same as the other two lines in this block
LocationServices/LocationServicesTests/Mocks/TrackingAPIServiceMock.swift
Show resolved
Hide resolved
cgalvan
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ALS-1805
Description of changes: