ALS-1813 Update place popup: show new information and other fixes #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… number, etc – anything included in the new data from V2 API for the location) ALS-1908 [iOS] Use center of the map for bias position ALS-1821 [iOS] Update routes: support EV & Scooter travel modes ALS-1892 iOS-Mobile > Route > Navigation auto adjusts to starting point ALS-1900 iOS-Mobile > The Map does not render if zoomed out ALS-1901 iOS-Mobile > Search > Moving to different location does not give the desired result ALS-1811 [iOS] Update search: use result type, query type and terms to search text ALS-1897 iOS-Mobile > Route > Entering Inverse geocode is showing error ALS-1912 [iOS] Separate map language dropdown in map styles Updated gems
ALS-1813 Update place popup: show new information and other fixes
Update SettingsUITests.swift
Comment on lines
51
to
52
| static let direction = "Directions" | ||
| static let directions = "Directions" |
There was a problem hiding this comment.
If you no longer need a string that says "Direction", we should just use the existing directions string directly below this and delete direction.
Comment on lines
79
to
111
| if language == "zh-Hant" { | ||
| // Special handling for zh-Hant | ||
| return [ | ||
| "coalesce", | ||
| ["get", "name:zh-Hant"], | ||
| ["get", "name:zh"], | ||
| ["get", "name:en"], | ||
| ["get", "name"] | ||
| ] | ||
| } | ||
|
|
||
| if let arrayExp = exp as? [Any] { | ||
| guard arrayExp.first as? String == "coalesce" else { | ||
| return arrayExp.map { recurseExpression(exp: $0, prevPropertyRegex: prevPropertyRegex, nextProperty: nextProperty, language: language) } | ||
| } | ||
|
|
||
| guard arrayExp.count > 2, | ||
| let first = arrayExp[1] as? [Any], first.first as? String == "get", | ||
| let firstProperty = first.last as? String, | ||
| let _ = firstProperty.range(of: prevPropertyRegex, options: .regularExpression), | ||
| let second = arrayExp[2] as? [Any], second.first as? String == "get" else { | ||
| return arrayExp.map { recurseExpression(exp: $0, prevPropertyRegex: prevPropertyRegex, nextProperty: nextProperty, language: language) } | ||
| } | ||
|
|
||
| return [ | ||
| "coalesce", | ||
| ["get", nextProperty], | ||
| ["get", "name:en"], | ||
| ["get", "name"] | ||
| ] | ||
| } | ||
|
|
||
| return exp |
There was a problem hiding this comment.
Shouldn't the special-case handling for zh-Hant appear at the bottom of this method after the possible recursion calls instead of before?
mbalfour-amzn
approved these changes
Dec 4, 2024
cgalvan
approved these changes
Dec 4, 2024
| } else { | ||
| searchType = .search | ||
| } | ||
| //$0.placeId != nil ? .location : .search |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ALS-1813 [iOS] Update place popup: show new information (hours, phone number, etc – anything included in the new data from V2 API for the location)
ALS-1908 [iOS] Use center of the map for bias position
ALS-1821 [iOS] Update routes: support EV & Scooter travel modes
ALS-1892 iOS-Mobile > Route > Navigation auto adjusts to starting point
ALS-1900 iOS-Mobile > The Map does not render if zoomed out
ALS-1901 iOS-Mobile > Search > Moving to different location does not give the desired result
ALS-1811 [iOS] Update search: use result type, query type and terms to search text
ALS-1897 iOS-Mobile > Route > Entering Inverse geocode is showing error
ALS-1912 [iOS] Separate map language dropdown in map styles
Updated gems