Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1: bumping version + updating docs #2

Merged
merged 10 commits into from
Mar 17, 2025
Merged

v1: bumping version + updating docs #2

merged 10 commits into from
Mar 17, 2025

Conversation

alexa-perlov
Copy link
Collaborator

No description provided.

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

Hi there,

I am commenting because your project has not yet been published and you have opened a pr to the main branch.

If you are ready to publish, please issue the following comment on this PR and I will initiate the publication review
process:

/confirm-publication

If you require more information please reach out to your AWS contact assisting you with this project.

MichaelWalker-git
MichaelWalker-git previously approved these changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@MichaelWalker-git MichaelWalker-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexa-perlov
Copy link
Collaborator Author

/do-e2e-tests

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

End to end test has been scheduled

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

aws-ia-automator-prod[bot]
aws-ia-automator-prod bot previously approved these changes Feb 25, 2025
View reviewed changes
Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests completed successfully

@alexa-perlov alexa-perlov changed the title bumping verion v1: bumping version + updating docs Feb 26, 2025
@alexa-perlov
Copy link
Collaborator Author

/do-e2e-tests

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

End to end test has been scheduled

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

1 similar comment
@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

aws-ia-automator-prod[bot]
aws-ia-automator-prod bot previously approved these changes Feb 26, 2025
View reviewed changes
Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests completed successfully

@alexa-perlov
Copy link
Collaborator Author

/do-e2e-tests

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

End to end test has been scheduled

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

1 similar comment
@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

aws-ia-automator-prod[bot]
aws-ia-automator-prod bot approved these changes Feb 27, 2025
View reviewed changes
Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests completed successfully

MichaelWalker-git
MichaelWalker-git previously approved these changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@MichaelWalker-git MichaelWalker-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Really nice job here, Alexa!

@alexa-perlov
Copy link
Collaborator Author

/confirm-publication

aws-ia-automator-prod[bot]
aws-ia-automator-prod bot requested changes Feb 27, 2025
View reviewed changes
Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review has been requested from required contributors, once they have approved I will remove my request for changes. When this PR is merged your project will be published

@alexa-perlov
Copy link
Collaborator Author

/do-e2e-tests

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

End to end test has been scheduled

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

@alexa-perlov
Copy link
Collaborator Author

/do-e2e-tests

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

End to end test has been scheduled

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

1 similar comment
@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

aws-ia-automator-prod[bot]
aws-ia-automator-prod bot previously approved these changes Feb 28, 2025
View reviewed changes
Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests completed successfully

MichaelWalker-git
MichaelWalker-git previously approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@MichaelWalker-git MichaelWalker-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@novekm novekm self-requested a review February 28, 2025 20:46
@novekm
Copy link
Collaborator

novekm commented Mar 4, 2025

Please update the IAM Policies from using jsonencode() to the aws_iam_policy_document data source. Essentially with the data source you get some additional validation checks at the terraform validate stage that will help ensure functionality.

@alexa-perlov
Copy link
Collaborator Author

/do-e2e-tests

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

End to end test has been scheduled

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

1 similar comment
@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

@alexa-perlov
Copy link
Collaborator Author

/do-e2e-tests

aws-ia-automator-prod[bot]
aws-ia-automator-prod bot approved these changes Mar 17, 2025
View reviewed changes
Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests completed successfully

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

End to end test has been scheduled

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

1 similar comment
@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

aws-ia-automator-prod[bot]
aws-ia-automator-prod bot approved these changes Mar 17, 2025
View reviewed changes
Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests completed successfully

novekm
novekm approved these changes Mar 17, 2025
View reviewed changes
Copy link
Collaborator

@novekm novekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexa-perlov alexa-perlov merged commit 9cf8822 into main Mar 17, 2025
2 checks passed
@alexa-perlov alexa-perlov deleted the version-bump branch March 17, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelWalker-git MichaelWalker-git MichaelWalker-git approved these changes

@novekm novekm novekm approved these changes

@aws-ia-automator-prod aws-ia-automator-prod[bot] aws-ia-automator-prod[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexa-perlov @novekm @MichaelWalker-git