Add nightly dependency bump workflow #266
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This reverts commit a7863f5.
thpierce
reviewed
Nov 12, 2025
Contributor
thpierce
left a comment
thpierce
left a comment
There was a problem hiding this comment.
Only reviewed .github/workflows
Comment on lines
+8
to
+10
| push: | ||
| branches: | ||
| - zhaez/nightly-build |
| secrets: inherit | ||
| permissions: | ||
| id-token: write | ||
| contents: write |
Comment on lines
+51
to
+55
| - name: Check for breaking changes | ||
| id: breaking_changes | ||
| env: | ||
| OTEL_DOTNET_CORE_VERSION: ${{ steps.get_versions.outputs.otel_dotnet_core_version }} | ||
| run: python scripts/find_breaking_changes.py |
Contributor
There was a problem hiding this comment.
Why not check OTEL_DOTNET_INSTRUMENTATION_VERSION?
| echo "has_changes=true" >> $GITHUB_OUTPUT | ||
|
|
||
| git add . | ||
| git commit -m "chore: update OpenTelemetry dependencies to ${{ steps.get_versions.outputs.otel_dotnet_core_version }}" |
Contributor
There was a problem hiding this comment.
Why not OTEL_DOTNET_INSTRUMENTATION_VERSION?
| else | ||
| echo "Creating new PR..." | ||
| gh pr create \ | ||
| --title "Nightly dependency update: OpenTelemetry ${{ needs.update-dependencies.outputs.otel_dotnet_core_version }}" \ |
Contributor
There was a problem hiding this comment.
Why not OTEL_DOTNET_INSTRUMENTATION_VERSION?
Comment on lines
+126
to
+127
| - [OpenTelemetry .NET Core](https://github.com/open-telemetry/opentelemetry-dotnet/releases/tag/v${{ needs.update-dependencies.outputs.otel_dotnet_core_version }}): ${{ needs.update-dependencies.outputs.otel_dotnet_core_version }} | ||
| - OpenTelemetry .NET Contrib packages: Updated to latest available versions |
Contributor
There was a problem hiding this comment.
OTEL_DOTNET_INSTRUMENTATION_VERSION?
Why latest available versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add a workflow
nightly-build.ymlwith following actions:nightly-dependency-updatesbranchExample PR: #287
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.