Repository navigation
fix(data_classes): return None for the SQS attribute value an attribute does not carry - #8713
Open
anishmehta24 wants to merge 1 commit into
Open
anishmehta24 wants to merge 1 commit into
anishmehta24 wants to merge 1 commit into
Conversation
…te does not carry
|
leandrodamascena
approved these changes
Oct 31, 2026
leandrodamascena
left a comment
Contributor
There was a problem hiding this comment.
Thanks @anishmehta24, confirmed with a real event: I sent a message with String, Number and Binary attributes through a queue to a function and Lambda delivers only the field matching the type, so binary_value on the String one raises KeyError on develop and returns None with your change, same as the Pydantic model already does.
I'm approving now. This goes out in 3.40.0, so it will sit here for a while before I merge it. No rebase needed in the meantime, and you'll be credited in the release notes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue number: closes #8712
Summary
Changes
SQSMessageAttribute.string_valueandbinary_valueare typedstr | Nonebut indexed the dict directly. Lambda only includes the field matching the attribute's type (a String attribute has nobinaryValue, a Binary one nostringValue), so reading the other one raisedKeyError. Both now useself.get(...)and returnNone, which matches their type hints and the PydanticSqsMsgAttributeModel; the docstrings say when the value isNone.Added
test_sqs_message_attribute_with_only_one_valueintests/unit/data_classes/required_dependencies/test_sqs_event.pywith a String and a Binary attribute shaped like the Lambda docs example; it fails ondevelopwithKeyError: 'binaryValue'. The data classes and batch tests pass.User experience
Before:
record.message_attributes["text"].binary_valueon a String attribute raisesKeyError. After: it returnsNone.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.