Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: allow BaseProvider in Parameters to not have a client #2400

Closed
1 of 2 tasks
dreamorosi opened this issue Apr 18, 2024 · 4 comments · Fixed by #3564 or #3768
Closed
1 of 2 tasks

Feature request: allow BaseProvider in Parameters to not have a client #2400

dreamorosi opened this issue Apr 18, 2024 · 4 comments · Fixed by #3564 or #3768
Assignees
Labels
completed This item is complete and has been merged/shipped feature-request This item refers to a feature request for an existing or new utility parameters This item relates to the Parameters Utility

Comments

@dreamorosi
Copy link
Contributor

Use case

When creating a custom Parameters provider I should be able to seamless set my own backend, regardless of whether this might be AWS, a 3rd party, or anything else.

Currently the BaseProvider expects a constructor parameter called proto (as-in prototype, bad name) that you're supposed to pass and that will be used whenever you are not passing an AWS SDK client.

This implementation is too tightly coupled with the notion that BaseProvider expects to be extended by a provider that relies on an AWS SDK client. This is not always the case, and as a customer implementing my own provider I should not have to work around this limitation.

Solution/User Experience

For end customers using the Parameters utility as-is, the experience should stay the same.

For those other customers who implement their own provider, the implementation should be simpler and not require to pass a class prototype to be instantiated as client.

Alternative solutions

No response

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@dreamorosi dreamorosi added parameters This item relates to the Parameters Utility feature-request This item refers to a feature request for an existing or new utility discussing The issue needs to be discussed, elaborated, or refined labels Apr 18, 2024
@dreamorosi dreamorosi self-assigned this Feb 6, 2025
@dreamorosi dreamorosi moved this from Ideas to Backlog in Powertools for AWS Lambda (TypeScript) Feb 6, 2025
@dreamorosi
Copy link
Contributor Author

Since it's a 5 lines change, I'll work on it and open a PR during this iteration.

@dreamorosi dreamorosi moved this from Backlog to Working on it in Powertools for AWS Lambda (TypeScript) Feb 6, 2025
@dreamorosi dreamorosi added confirmed The scope is clear, ready for implementation and removed discussing The issue needs to be discussed, elaborated, or refined labels Feb 6, 2025
@dreamorosi dreamorosi moved this from Working on it to Pending review in Powertools for AWS Lambda (TypeScript) Feb 6, 2025
@github-project-automation github-project-automation bot moved this from Pending review to Coming soon in Powertools for AWS Lambda (TypeScript) Feb 6, 2025
Copy link
Contributor

github-actions bot commented Feb 6, 2025

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Feb 6, 2025
Copy link
Contributor

This is now released under v2.14.0 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Feb 11, 2025
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Feb 11, 2025
@dreamorosi dreamorosi reopened this Mar 24, 2025
@github-project-automation github-project-automation bot moved this from Shipped to Pending review in Powertools for AWS Lambda (TypeScript) Mar 24, 2025
@github-project-automation github-project-automation bot moved this from Pending review to Coming soon in Powertools for AWS Lambda (TypeScript) Mar 25, 2025
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped feature-request This item refers to a feature request for an existing or new utility parameters This item relates to the Parameters Utility
Projects
Status: Coming soon
1 participant