-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: allow BaseProvider
in Parameters to not have a client
#2400
Comments
Since it's a 5 lines change, I'll work on it and open a PR during this iteration. |
This issue is now closed. Please be mindful that future comments are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so. |
This is now released under v2.14.0 version! |
This issue is now closed. Please be mindful that future comments are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so. |
Use case
When creating a custom Parameters provider I should be able to seamless set my own backend, regardless of whether this might be AWS, a 3rd party, or anything else.
Currently the
BaseProvider
expects a constructor parameter calledproto
(as-in prototype, bad name) that you're supposed to pass and that will be used whenever you are not passing an AWS SDK client.This implementation is too tightly coupled with the notion that
BaseProvider
expects to be extended by a provider that relies on an AWS SDK client. This is not always the case, and as a customer implementing my own provider I should not have to work around this limitation.Solution/User Experience
For end customers using the Parameters utility as-is, the experience should stay the same.
For those other customers who implement their own provider, the implementation should be simpler and not require to pass a class prototype to be instantiated as client.
Alternative solutions
No response
Acknowledgment
Future readers
Please react with 👍 and your use case to help us understand customer demand.
The text was updated successfully, but these errors were encountered: