-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(parameters): update AWS SDK client type #3768
Conversation
I'm going to review this tomorrow morning. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good to me! Even though this is a simple example to show customers how to extend the parameter provider, I wouldn't show customers how to do this via HTTP call instead of Vault Client because customers need to deal with unseal, retry, certificate and so on, and using HTTP for that is super hard.
But it's just a comment! Approving.
I hear you, but that was an unofficial client and it was bringing some transitive dependencies that were causing GitHub alerts, so for this I'll leave it as is for now. |
Summary
Changes
This PR is a second attempt at fixing the issue described in the linked issue, which is to make the usage of a client in the
BaseProvider
class optional.The first PR updated the logic but omitted making the parameter optional in the types. This PR fixes that.
The PR also removes a 3rd party dependency on
hashi-vault-js
which was used in the examples, in favor of a much simpler and dependency free direct API call usingfetch
.Issue number: closes #2400
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.