Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(parameters): update AWS SDK client type #3768

Merged
merged 7 commits into from
Mar 25, 2025

Conversation

dreamorosi
Copy link
Contributor

Summary

Changes

Please provide a summary of what's being changed

This PR is a second attempt at fixing the issue described in the linked issue, which is to make the usage of a client in the BaseProvider class optional.

The first PR updated the logic but omitted making the parameter optional in the types. This PR fixes that.

The PR also removes a 3rd party dependency on hashi-vault-js which was used in the examples, in favor of a much simpler and dependency free direct API call using fetch.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #2400


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Mar 24, 2025
@boring-cyborg boring-cyborg bot added dependencies Changes that touch dependencies, e.g. Dependabot, etc. documentation Improvements or additions to documentation parameters This item relates to the Parameters Utility labels Mar 24, 2025
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Mar 24, 2025
@leandrodamascena
Copy link
Contributor

I'm going to review this tomorrow morning.

Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me! Even though this is a simple example to show customers how to extend the parameter provider, I wouldn't show customers how to do this via HTTP call instead of Vault Client because customers need to deal with unseal, retry, certificate and so on, and using HTTP for that is super hard.

But it's just a comment! Approving.

@dreamorosi
Copy link
Contributor Author

I hear you, but that was an unofficial client and it was bringing some transitive dependencies that were causing GitHub alerts, so for this I'll leave it as is for now.

@dreamorosi dreamorosi merged commit fa414d5 into main Mar 25, 2025
42 checks passed
@dreamorosi dreamorosi deleted the chore/update_parameters_type branch March 25, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes that touch dependencies, e.g. Dependabot, etc. documentation Improvements or additions to documentation parameters This item relates to the Parameters Utility size/L PRs between 100-499 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: allow BaseProvider in Parameters to not have a client
2 participants