Cleaning kendra-docs-index.yaml#25
Open
jwdinkel wants to merge 1 commit into
Open
Conversation
Simplified and aligned syntax. Fixed Python imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed python import and Use Sub instead of Join to make code more readable.
Issue #, if available:
Description of changes:
I have removed the import of random, which was not used.
I have also changed code to use inline variables rather than the multi-line syntax that was used before with Sub and with Join. This reduces the code by 30 lines and makes it look much cleaner in code editors that highlight the variables. In addition, the Type fields are consistent now with quotes rather than having just some that are quoted in the prior version. And I corrected a small grammar error in the comment.
Hopefully, you will agree, this is much cleaner.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.