Skip to content

Commit

Permalink
Update libraries (#36)
Browse files Browse the repository at this point in the history
* Update deps

* Add cfn tests

* Reduce two approvers to one

* Update python packages

* Fix nag issues

* Bump node to 14.x

* Bump version

* Apply suggestions from code review

Sorry, missed those.

Co-authored-by: Matteo Figus <[email protected]>

* Update .github/workflows/unit-tests.yaml

* Update .github/workflows/unit-tests.yaml

* Update .github/workflows/unit-tests.yaml

* Update .github/workflows/unit-tests.yaml

* Fix indention

* Fix npm test

* Update src/cfn/template.yaml

Co-authored-by: Matteo Figus <[email protected]>

* Fix invalid error from cfn-lint

* Bump requirements.txt

Co-authored-by: Matteo Figus <[email protected]>
  • Loading branch information
rezabekf and matteofigus committed May 18, 2022
1 parent 5417aff commit 8663c47
Show file tree
Hide file tree
Showing 9 changed files with 36,503 additions and 42,214 deletions.
3 changes: 3 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# These owners will be the default owners for everything in the repo.
# @aws-uk-solution-builders will be requested for review when someone opens a pull request.
* @aws-samples/aws-uk-solution-builders
4 changes: 2 additions & 2 deletions .github/workflows/publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@ jobs:
uses: actions/setup-python@v1
with:
python-version: 3.7
- name: Set up Nodejs 12
- name: Set up Nodejs 16
uses: actions/setup-node@v1
with:
node-version: 12
node-version: 16
- name: Install node dependencies
run: npm i
- name: Install python dependencies
Expand Down
51 changes: 51 additions & 0 deletions .github/workflows/unit-tests.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
name: Unit Tests
on:
push:
branches:
- master
pull_request:
types:
- opened
- edited
- synchronize
jobs:
unit_tests:
name: Unit tests
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2

# Cache
- uses: actions/cache@v1
with:
path: ~/.cache/pip
key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements.txt') }}
restore-keys: |
# Setup
- name: Set up Nodejs 16
uses: actions/setup-node@v1
with:
node-version: 16
- name: Set up Python
uses: actions/setup-python@v2
with:
python-version: '3.10' # have to use quotes due to 0 being removed
- name: Install node dependencies
run: npm i
- name: Install python packages
run: pip install -Ur requirements.txt
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.1
- name: Install Ruby gems
run: gem install cfn-nag

# Run Tests
- name: Frontend unit tests
run: npm test
- name: CloudFormation lint test
run: cfn-lint src/cfn/**/*.yaml
- name: CloudFormation nag test
run: cfn_nag_scan --input-path src/cfn
Loading

0 comments on commit 8663c47

Please sign in to comment.