Updates for SMStudio 2024+ and newer DLC versions #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to cdk-ecr-deployment v3 to resolve deployment failure due to deprecated AWS Lambda Go v1.x runtime.
Update CloudFormation bootstrap template for cfn-nag permissions findings, to ensure `requests` install for CFn callback, and to update from soon-EoL Python 3.8 Lambda runtime.
Update CDK OCR & thumbnailer deployments to PyTorch 2.2 inference container. Still TODO: Update notebooks once validated.
Force building the Lambda from scratch as per comments on: cdklabs/cdk-ecr-deployment#651
Update main notebook flow to work with SageMaker Studio JupyterLab spaces (replacing SMStudio Classic since 2023-12) and upgrade SM HuggingFace container bases. Also upgrade TRP.js to latest version.
v3 flagged by npm audit
Using PDFjs v4 requires us to shift the main app entrypoint to an ES module, which in turn requires a workaround because SMGT/A2I environment will not *actually run* module scripts by default due to the way the user content iframe gets initialised. We could probably consider switching TRP.js imports to ESM now too!
Run npm update & fix tsconfig for current versions of base libs.
Update extras notebook for 2024+ SMStudio, new HF container versions. Also fix bootstrap scale-up-from-zero not getting triggered because CW alarm was not initialised.
Not had time to fix this yet but the rest of the flow is updated already so want to prioritize visibility at least.
Tested the notebooks end-to-end on v1.9 with no issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #46, #47
Description of changes:
Updating the stack & sample to:
Testing done:
Tested end-to-end deployment (via bootstrap stack) in a fresh environment, and been through Optional Extras notebook also. Not yet updated the old "Workshop" notebook, but added a caveat to the top of it to indicate it's outdated.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.