AWS CloudTrail Trail Creation added in the template #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplate through a configurable parameter. Updated the README accordingly both in the parameter section and in the cleanup
|
Hey @Cerrix - can you comment more on "This is needed by the tool to work properly."? I am in the process of updating the project and I want to understand why the solution did not work for you as-is. In particular - does this PR solve any of the open issues? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the possibility to create an AWS CloudTrail Trail inside the SAM Template. This is needed by the tool to work properly. Indeed, the tool needs at least one trail able to record management events to trigger correctly the Amazon Event Bridge rules.
Issue #, if available:
NA
Description of changes:
Template.yaml: now takes a new parameter CreateTrail [yes/no] which enables the creation of:
README.MD is updated to reflect the template changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.