Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding Kotlin examples for Working with Items #154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: adding Kotlin examples for Working with Items #154

wants to merge 1 commit into from

Conversation

plastic-karma
Copy link
Contributor

tebanieo
tebanieo requested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@tebanieo tebanieo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took me so long to review this code. Can you please match the read operations with the ids that you wrote? instead of using YourPrimaryKeyValue can you use the 1234 and 1235 examples you wrote in the operations? I started commenting on the individuals but I realized it was the same across the examples.

examples/SDK/kotlin/data_plane/WorkingWithItems/src/main/kotlin/BatchGetItem.kt
val tableName = "YourTableName"
val keys =
listOf(
mapOf("PrimaryKey" to AttributeValue.S("YourPrimaryKeyValue1")),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is nice if you match the PrimaryKeyValue1 and PrimaryKeyValue2 to the examples 1234 and 1235 that you created with the Write operations, just for uniformity.

For a new user it will also help on the understanding.

examples/SDK/kotlin/data_plane/WorkingWithItems/src/main/kotlin/DeleteItem.kt

suspend fun main() {
val tableName = "YourTableName"
val key = mapOf("PrimaryKey" to AttributeValue.S("YourPrimaryKeyValue"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment than the BatchGetItem.kt file, please match with the ids that are written.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tebanieo tebanieo tebanieo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plastic-karma @tebanieo