adding ACM Cert Arn as a parameter for WebUICDN CloudFront distribution #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastLeblanc
reviewed
Sep 20, 2023
| @@ -466,6 +466,10 @@ Parameters: | |||
| Default: 'nr50Qdu7FM94n2X1GYuhA8cFzyvdYTJ5Qka4XMOd' | |||
| NoEcho: true | |||
|
|
|||
| ACMCertificateArn: | |||
There was a problem hiding this comment.
this parameter should be added in the "Optional Integrations" group to avoid having it floating at the end (it looks like it's part of the Fenix integration)
And add a comment that is optional only required for deployment with a custom CNAME domain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Added the ACM Cert Arn as a parameter, to enable automated blue-green deployment.
Description of testing performed to validate your changes (required if pull request includes CloudFormation or source code changes):
Re-staged bucket then redeployed by adding a ACM cert ARN. Distribution is created with the correct certificate attached.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.