Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfn-lint, Cloudfront cname support etc... #509

Merged
merged 14 commits into from
Nov 20, 2023

Conversation

BastLeblanc
Copy link
Contributor

@BastLeblanc BastLeblanc commented Nov 3, 2023

Issue #, if available:

Description of changes:

  • support for custom cname in cloudfront
  • various cfn-lint cleanup
  • new optional parameters ResourceBucketImages and ResourceBucketImagesPrefix to use images from another bucket.

Description of testing performed to validate your changes (required if pull request includes CloudFormation or source code changes):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@BastLeblanc BastLeblanc marked this pull request as ready for review November 14, 2023 14:21
@BastLeblanc BastLeblanc requested a review from gfaires November 17, 2023 16:51
@BastLeblanc BastLeblanc self-assigned this Nov 17, 2023
Copy link
Contributor

@gfaires gfaires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gfaires gfaires merged commit 746bb2b into aws-samples:master Nov 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Shipped
Development

Successfully merging this pull request may close these issues.

2 participants