Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deploy-cfn-script): add S3_PATH param #634

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

YutaOkoshi
Copy link
Contributor

@YutaOkoshi YutaOkoshi commented Sep 17, 2024

Issue #, if available:

Description of changes:
S3_PATH can be specified as a parameter when deploying with a script.

Description of testing performed to validate your changes (required if pull request includes CloudFormation or source code changes):

@YutaOkoshi YutaOkoshi marked this pull request as ready for review September 17, 2024 04:29
@YutaOkoshi
Copy link
Contributor Author

@BastLeblanc @gfaires
hi, how about this pr?

@BastLeblanc
Copy link
Contributor

Thanks for your contribution ! merging it now.

Copy link
Contributor

@BastLeblanc BastLeblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BastLeblanc BastLeblanc merged commit d33ea5b into aws-samples:master Sep 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Shipped
Development

Successfully merging this pull request may close these issues.

2 participants