-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Pattern Submission: AWS API Gateway IAM authorization and AWS v4 request signing (sls & Python) #2044
New Pattern Submission: AWS API Gateway IAM authorization and AWS v4 request signing (sls & Python) #2044
Conversation
Clean up serverless.yml Clean up serverless.yml Rename project folder and serverless.yaml clean-up Refactor codebase and folder structure
97cb3e9
to
61bfdab
Compare
@cornelcroi @bls20AWS fyi, moved the PR from draft to review. |
@undefined your 'example-pattern.json' is missing some key fields, please review below and address any errors you have
If you need any help, take a look at the example-pattern file. Make the changes, and push your changes back to this pull request. When all automated checks are successful, the Serverless DA team will process your pull request. |
e663c29
to
68270f3
Compare
a60906a
to
35fcc8d
Compare
@cornelcroi @bls20AWS FYI, the description char limit is fixed. |
Valid pattern file found. Reviewer you can view the pattern file here |
Hi @bb245, I've reviewed the code and tried to understand from the readme what is the purpose of the pattern and here are my remarks:
I suggest you find another implementation to demonstrate how to sign requests. |
c67874f
to
3162f6f
Compare
3162f6f
to
112ddc3
Compare
Hi @cornelcroi, I updated the implementation & request your review. Thank you. |
Hi @bb245, Thanks for the update. |
Issue #, if available: #2045
Description of changes:
This pattern involves employing an AWS_IAM authorizer to secure an API endpoint through Python 3 and the Serverless framework. It illustrates the process of signing the HTTP request using IAM credentials and adhering to the AWS v4 signing process. This ensures access to the protected endpoint from a public API. The interaction with APIs is facilitated by AWS API Gateway.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.