Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update terraform samples without JS SDK from node 16 to 20 #2295

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Jun 3, 2024

Issue #, if available:

Description of changes:
Updates terraform samples without JS SDK from node 16 to 20

The terraform samples which use AWS SDK for JavaScript need migration to v3, and are being migrated in #2294

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ellisms
Copy link
Contributor

ellisms commented Jun 10, 2024

Thanks for the submission @trivikr . Can you please update the AWS Provider package version in the patterns you updated? It looks like nodejs20.x is available in v5.27.0 and the few TF files I checked have a version operator that won't allow upgrading to a newer major version.

@trivikr trivikr force-pushed the terraform-lambda-node-16-to-20 branch from 1770ab5 to fbe0284 Compare June 10, 2024 13:49
@trivikr trivikr marked this pull request as draft June 10, 2024 13:53
@trivikr
Copy link
Contributor Author

trivikr commented Jun 10, 2024

I noticed that most of the AWS Provider versions are 4.x, and some are 3.x
They should be updated to 5.x outside of this PR to handle major version bump, and this PR can be revisited later.

Converting to draft.
I've created feature request for updating to terraform 5.x at #2308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants