-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New serverless pattern - lambda-cloudwatch-subscription-sns-notification #2517
base: main
Are you sure you want to change the base?
New serverless pattern - lambda-cloudwatch-subscription-sns-notification #2517
Conversation
dc5fd25
to
c7258fe
Compare
Hello Team, could you please have a look at this PR? |
3310406
to
cd2fd5b
Compare
Hi @shubsmor ,
If there is no major difference, we may not be able to proceed with this review.
|
d8c61ef
to
08797e5
Compare
Hi @biswanathmukherjee, Thanks for looking into the project and suggesting the changes. Having said that, as per your suggestion I have removed the similar pattern from this PR. Currently this pattern implements comprehensive alerting system using account level CloudWatch subscription filter which automatically starts monitoring any existing and new loggroups without binding it to the loggroups created as part of the pattern itself like https://serverlessland.com/patterns/cwlogs-lambda-sns-sqs-cdk Additionally, there is no pattern demonstrating account level subscription filter as well as documentation on implementing same using any IAC. Lastly, I have also rectified typos. Could you please check again ? |
cloudwatch-account-subscription-Lambda-sns-notification/example-pattern.json
Outdated
Show resolved
Hide resolved
cloudwatch-account-subscription-Lambda-sns-notification/README.md
Outdated
Show resolved
Hide resolved
cloudwatch-account-subscription-Lambda-sns-notification/example-pattern.json
Outdated
Show resolved
Hide resolved
…n system using Lambda and CloudWatch log subscription filter and sns
08797e5
to
8bd8f36
Compare
I have corrected the files as suggested. Could you please have a look at this again ? |
Thanks for your contribution. Approved from my side. DA will perform the next review. |
This sample project demonstrates an alerting system using CloudWatch Logs Subscription filter to a Lambda function to trigger a SNS notification when the original function encounters timeout
two Lambda functions - sample Lambda [ to demonstrate timeout ] , notification Lambda [Is triggered by CloudWatch log Subscription and publish a SNS message]