Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New serverless pattern - lambda-cloudwatch-subscription-sns-notification #2517

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shubsmor
Copy link

This sample project demonstrates an alerting system using CloudWatch Logs Subscription filter to a Lambda function to trigger a SNS notification when the original function encounters timeout

  • Currently we dont have out of box offering to alert the customer when there Lambda function encounters timeout. For time sensitive applciations Customer would like to get notification when their Lambda function is timedout",
  • This pattern deploys one SNS topic with email subsciption, CloudWatch loggroup and Subscription filter,
    two Lambda functions - sample Lambda [ to demonstrate timeout ] , notification Lambda [Is triggered by CloudWatch log Subscription and publish a SNS message]

@shubsmor shubsmor force-pushed the shubsmor-lambda-cloudwatch-subscription-sns-notification branch 2 times, most recently from dc5fd25 to c7258fe Compare November 29, 2024 04:01
@shubsmor
Copy link
Author

Hello Team, could you please have a look at this PR?

@shubsmor shubsmor force-pushed the shubsmor-lambda-cloudwatch-subscription-sns-notification branch from 3310406 to cd2fd5b Compare December 12, 2024 10:30
@biswanathmukherjee
Copy link
Contributor

Hi @shubsmor ,
I see an existing similar pattern: https://serverlessland.com/patterns/cwlogs-lambda-sns-sqs-cdk

  1. How is this pattern different from the above?

If there is no major difference, we may not be able to proceed with this review.

  1. If there are major differences and we are ok to proceed, then also we can not club multiple patterns together. Also there are a lot of typos in the text.

@shubsmor shubsmor force-pushed the shubsmor-lambda-cloudwatch-subscription-sns-notification branch 2 times, most recently from d8c61ef to 08797e5 Compare December 22, 2024 14:57
@shubsmor
Copy link
Author

shubsmor commented Dec 22, 2024

Hi @biswanathmukherjee, Thanks for looking into the project and suggesting the changes.
I would like to share one the first pattern showcase the loglevel subscription filter, as you mentioned it is similar to pattern you shared. However, kindly note that my pattern came out of custom case and specifically was designed for time sensitive application.

Having said that, as per your suggestion I have removed the similar pattern from this PR. Currently this pattern implements comprehensive alerting system using account level CloudWatch subscription filter which automatically starts monitoring any existing and new loggroups without binding it to the loggroups created as part of the pattern itself like https://serverlessland.com/patterns/cwlogs-lambda-sns-sqs-cdk

Additionally, there is no pattern demonstrating account level subscription filter as well as documentation on implementing same using any IAC.

Lastly, I have also rectified typos. Could you please check again ?

…n system using Lambda and CloudWatch log subscription filter and sns
@shubsmor shubsmor force-pushed the shubsmor-lambda-cloudwatch-subscription-sns-notification branch from 08797e5 to 8bd8f36 Compare January 14, 2025 15:52
@shubsmor
Copy link
Author

I have corrected the files as suggested. Could you please have a look at this again ?

@biswanathmukherjee
Copy link
Contributor

Thanks for your contribution. Approved from my side. DA will perform the next review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants