Typescript test sample: Apigw, Lambda and external API #297
Conversation
|
Hi @RedHeadDigital, thanks for the Pull Request! Just wanted to make sure you know we saw it come through - I'm hoping to take a closer look this week (between re:Invent sessions 😄 ) |
There was a problem hiding this comment.
Hi Mark!
Thanks for your patience waiting for us to take a closer look. Love the work you've done here and I'm excited to get it included in our repo.
I tried out the instructions, and it worked as expected for me.
I included some comments in the README to get fixed up - stuff like broken links. I'd also love to see a bit deeper explanation of the pattern you're using here. Content like why its useful, when to use it, and what tradeoffs you take when going this route.
Happy to take thoughts and feedback on my comments as well!
Thanks again!
|
Hi @brnkrygs, Thank you for your thorough review. I really appreciate the feedback on where to articulate my intent with the pattern I have showcased here. I hope I've understood and addressed everything you've highlighted. Thanks again |
brnkrygs
added
the
typescript
|
Hi @RedHeadDigital! Appreciate the updates, looks like we're making solid progress! With the tweak adding the Conditional to the MockAPI, I'm seeing an error trying to deploy when Could you take a look when you get a moment? Then, last change I've found is to adjust the folder name for your example. If you're contributing on behalf of an organization, we've been appending the organization name to the end of the folder path (check out Datadog's contribution as an example). Also, apologies for the delayed review. |
|
Hi @brnkrygs Sure! I'll take a look into that failure 👍🏻 Do you have any guidance on the determining factors for submitting on behalf of an organisation or submitting as an individual? Thanks |
Regarding guidance for organization vs. individual... checking with our team. |
No strong guidance at the moment. Its more about if you see yourself as representing your organization or not. How are you approaching this one? |
|
I'd say that I'm representing myself for this one as the PR for this pattern has emerged from a blog post I wrote that I felt required more detail when focusing on a serverless platform. Blog: Serverless: Are you seeking confidence from the wrong place? |
Sounds good. Last step is to verify that you approve contributing under the License, per the Contributing guidelines. After that I can merge! |
|
I approve this pull request & contribution as per the License set out as part of the Contributing documentation 👍🏻 Thanks again! |
|
Hi @brnkrygs, Just curious when this pattern will appear on the site? Thanks |
Its merged into the main project repo now, from what I can see. Or, are you talking about a different site? |
|
Hi @brnkrygs, Maybe it's a misunderstanding I have. I initiated this patterns creation via https://serverlessland.com/testing/patterns, it was my assumption a merge into main would appear on that site. Thanks |
|
Ah, OK. No misunderstanding there. It should be synchronized over to that site. I'll check into the process on our side and see if I can find out what's happening there. Thanks for checking in. |
|
Hi @RedHeadDigital - we were finally able to clean up the sync process and your pattern is now live on serverlessland. Thanks for your patience! https://serverlessland.com/testing/patterns/typescript-test-samples-apigw-lambda-external |
|
Hi @brnkrygs Thanks for the update! Great to see it live 🥳 |
Issue #, if available:
Description of changes:
This example contains basic examples of TypeScript tests, unit and integration, for AWS API Gateway, Lambda and external APIs where the external API is mocked in a volatile environment.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.