Add entity integration tests for statsd and collectd metrics #463
Conversation
Co-authored-by: Travis Stark <[email protected]>
* Copy amp destination test to amp histogram test * Only generate histogram test * Refactoring all AMP tests into one. Need to rename later * add more metric types * Rough test for all supported metrics * Code cleanup * Bump linter version Previous version crashes * Move new test logic back to original folder * more code cleanup * Surpress s3 cp progress * surpress git clone progress * otlp_pusher.sh can be executed * few debugging improvements * Minor error handling improvement * restore test case generator * Move amp test up to main directory * Address code review comments * Remove unused label for prometheus
|
Could you add a sample snippet/screenshot showing specifically how this test output is different after this change? |
The actual test output is unchanged. This PR uses existing StatsD/CollectD tests and adds an extra validation step to check that an entity is being sent with these metrics. |
|
Can we modify the test code so we can explicitly see if entity tests passed? Maybe as a separate row of test case For example, looking at StatsD and CollectD section of the test output: https://github.com/aws/amazon-cloudwatch-agent/actions/runs/13681447031/job/38254861506#step:7:3088 It's unclear whether the entity is tested or not because this PR is re-using existing test logic then adding on the entity check into that. |
test/metric/statsd_util.go
Outdated
|
|
||
| switch computeType { | ||
| case "EC2": | ||
| requestBody = []byte(fmt.Sprintf(`{ |
There was a problem hiding this comment.
Can we make a helper function to create these requests dynamically? Something that inputs dynamic amount of dimensions with their values? It would make the code here less clunky
|
Modified the tests so that they would be visible in the test results: Examples: https://github.com/aws/amazon-cloudwatch-agent/actions/runs/13688151654/job/38276163158#step:7:811 |
Description of the issue
We are currently missing integration tests that ensure that we are sending a service entity when publishing statsd/collectd metrics.
Description of changes
Added to the existing statsd/collectd tests to make a
ListEntitiesForMetriccall to validate that an entity is being sent.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. ✅
Tests
Integration test run: https://github.com/aws/amazon-cloudwatch-agent/actions/runs/13688151654