Fix issues with PerformanceReport Page (commit data, hiding missing data) #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisStark
force-pushed
the
feature/performance-report
branch
from
d48f203 to
0712349
Compare
TravisStark
force-pushed
the
feature/performance-report
branch
from
0712349 to
465a163
Compare
okankoAMZ
reviewed
Dec 11, 2024
|
This PR was marked stale due to lack of activity. |
TravisStark
force-pushed
the
feature/performance-report
branch
from
465a163 to
e1c3dda
Compare
okankoAMZ
approved these changes
Jan 3, 2025
…ata) and increase Axios timeout. Additional null handling and performance improvements
TravisStark
force-pushed
the
feature/performance-report
branch
from
e1c3dda to
3217aae
Compare
|
Are you able to show what the page looked before your changes? |
|
I see the commit date in the screenshot is 1969, is this based on some fallback? |
|
musa-asad
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Fixes issues with PerformanceReport Page
Description of changes
Note:
Date shows as Dec 31, 1969, this is due to commit data missing in DynamoDB and will be resolved by another PR in the CWAgent Integ tests
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lintScreenshots
Before
After