[Windows] refactor stats package to fetch EBS Volume stats for Windows #4217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Presently, the code path in stats package of the agent, which invokes the CSI Client to fetch volume metrics is limited to Linux platform only. The same code path can be used for Windows as well. This change refactors the existing code to ensure that the EBS volume stats are collected for Windows as well in addition to Linux.
saurabhc123
approved these changes
Jun 27, 2024
| derivedCtx, cancel := context.WithTimeout(engine.ctx, time.Second*1) | ||
| // releases resources if GetVolumeMetrics finishes before timeout | ||
| defer cancel() | ||
| return engine.csiClient.GetVolumeMetrics(derivedCtx, volumeId, hostPath) |
There was a problem hiding this comment.
Is this method implemented for Windows?
There was a problem hiding this comment.
Yes the code path is common for both Linux and Windows-
GetVolumeMetrics depends upon few methods-
NodeGetVolumeStatsfromCSI Driverwhich is dependent upon the following-PathExistsinmounterpackageIsBlockDeviceinutilspackagegetBlockSizeBytesfromCSI DriverGetMetricsfromCSI DrivergetFsInfoInfomethod fromfspackage
From the list above, the following methods are implemented as part of the PR you raised- #4214
PathExistsgetBlockSizeBytesInfo
IsBlockDevice method is part of #4224.
xxx0624
reviewed
Jul 1, 2024
| func (engine *DockerStatsEngine) getEBSVolumeMetrics(taskArn string) []*ecstcs.VolumeMetric { | ||
| task, err := engine.resolver.ResolveTaskByARN(taskArn) | ||
| if err != nil { | ||
| logger.Error(fmt.Sprintf("Unable to get corresponding task from dd with task arn: %s", taskArn)) |
There was a problem hiding this comment.
are we ignoring the error intentionally? If so, can we log the error as well?
There was a problem hiding this comment.
This is from the existing code which has been refactored into platform agnostic file.
Also, the logger.Error method does log the error via logrus. Reference-
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Presently, the code path in
stats packageof the agent, which invokes the CSI Client to fetch volume metrics, is limited to Linux platform only. The same code path can be used for Windows as well.This change refactors the existing code to ensure that the EBS volume stats are collected for Windows as well in addition to Linux.
Implementation details
Refactor the code from Linux specific files to common platform files.
Testing
Using unit and integration tests for Windows and Linux.
New tests cover the changes: N/A
Description for the changelog
refactor stats package to fetch EBS Volume stats for Windows
Does this PR include breaking model changes? If so, Have you added transformation functions?
NoLicensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.