make fluentd-async-connect configurable #4476
Merged
+133
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singholt
force-pushed
the
firelens-async-config
branch
6 times, most recently
from
13df33a to
000ccbd
Compare
singholt
changed the title
singholt
changed the title
singholt
force-pushed
the
firelens-async-config
branch
from
000ccbd to
4fe805f
Compare
sparrc
approved these changes
Jan 31, 2025
singholt
force-pushed
the
firelens-async-config
branch
from
4fe805f to
5c1c646
Compare
prateekchaudhry
approved these changes
Feb 1, 2025
singholt
force-pushed
the
firelens-async-config
branch
from
5c1c646 to
ea50d01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the
--fluentd-async-connectoption of the fluentd log driver configurable via the agent config. This option specifies whether the log driver connects to the Firelens sidecar container asynchronously or not.Since the launch of ECS Firelens, this option has been hard-coded to true (enabled) in the ECS agent. Recently, we've had a customer report log loss during task shutdown, especially when the app container emits logs at a high throughput. We've identified that disabling the async connection option increases reliability and prevents log loss.
This configurable setting gives customers an option to turn on/off the async option as per their use-case. Additionally, we will work with the upstream Docker community and AWS container runtime team to identify improvements within the log driver itself.
Implementation details
ECS_ENABLE_FIRELENS_ASYNCwhich translates to theFirelensAsyncEnabledagent config option. This defaults to true, preserving the current agent behavior.Testing
New tests cover the changes: yes
Description for the changelog
Enhancement: make the fluentd-async-connect log driver option configurable.
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Does this PR include the addition of new environment variables in the README?
Yes, updated the README.Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.