More robust MySQL catalog usage detection #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiyvamz
approved these changes
Jan 9, 2025
crystall-bitquill
approved these changes
Jan 14, 2025
|
Thanks for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current MySQL catalog detection uses substring match to detect if a query makes use of a
USEstatement. The usage of substring match is brittle and fails if any part of the statement (other than a comment) has the substringuse.This is problematic as
useris a very common table name and gets mistakenly detected.Description
This PR changes the substring match to a more robust regular expression. I also added a few tests cases.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.