Passthrough source error as cause to AwsWrapperError constructor
#375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@karenc-bq @crystall-bitquill @sergiyvamz Tagging y'all because you reviewed and merged my previous PR. Thanks for looking at my PR. |
sophia-bq
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Hi @adrianfalleiro,
Thank you for reaching out and raising this. Looks like a good change to me.
|
Hi @adrianfalleiro, Thank you once again for your PR. I'd be happy to merge this change in for you, the branch just needs to be up to date with main. Would you like to update the branch or shall I? |
|
@sophia-bq thanks! Just updated it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Passes through the source error from the pg/mysql driver to the
AwsWrapperErrorconstructor.Description
I am currently using the
mysql2library and looking to integrate this wrapper with my project. The exceptions thrown bymysql2include extra details that are useful for handling the error (code, errno, sqlState, sqlMessage and sql).When this library throws an error, these details are lost because the error is wrapped in an
AwsWrapperErrorand only the message is preserved. I noticed that this class accepts an optionalcausein the constructor...but it's not being passed inClientUtils.queryWithTimeout(). This PR fixes that.Didn't add a test as I was unsure where it would belong. Happy to add one.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.