Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error retrieving keep alive settings #395

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

karenc-bq
Copy link
Contributor

@karenc-bq karenc-bq commented Feb 3, 2025

Summary

Calling keepAliveProps.get(...) will throw errors instead of returning undefined because keepAliveProps is not a map object.

Description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@karenc-bq karenc-bq requested a review from a team as a code owner February 3, 2025 21:40
@@ -76,7 +76,7 @@ export class MySQL2DriverDialect implements DriverDialect {
}

setKeepAliveProperties(props: Map<string, any>, keepAliveProps: any) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is keepAliveProps a consistent type? Could add that instead of having any?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to keep it as any so users can pass the keepAliveProps as either a map or an object:

  const keepAliveProps = new Map<string, any>([
      ["keepAlive", true],
      ["keepAliveInitialDelayMillis", 1234]
    ]);

  const keepAliveObj = {
    keepAlive: true,
    keepAliveInitialDelayMillis: 1234
  };

@karenc-bq karenc-bq force-pushed the fix/keep-alive-configurations branch from c572332 to 465e2fa Compare February 6, 2025 00:07
@karenc-bq karenc-bq force-pushed the fix/keep-alive-configurations branch from 465e2fa to 5b3e3c3 Compare February 7, 2025 01:09
@karenc-bq karenc-bq enabled auto-merge (squash) February 7, 2025 03:14
@karenc-bq karenc-bq merged commit 4e4760d into main Feb 7, 2025
2 checks passed
@karenc-bq karenc-bq deleted the fix/keep-alive-configurations branch February 7, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants