Skip to content

Updated the Go 1.18 version used by tls-with-acm walkthrough #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updated the Go 1.18 version used by tls-with-acm walkthrough #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions walkthroughs/tls-with-acm/src/colorteller/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ RUN yum update -y && \
yum clean all && \
rm -rf /var/cache/yum

RUN curl -LO https://golang.org/dl/go1.17.1.linux-amd64.tar.gz && \
tar -C /usr/local -xzvf go1.17.1.linux-amd64.tar.gz
RUN curl -LO https://golang.org/dl/go1.18.1.linux-amd64.tar.gz && \
tar -C /usr/local -xzvf go1.18.1.linux-amd64.tar.gz

ENV PATH="${PATH}:/usr/local/go/bin"
ENV GOPATH="${HOME}/go"
Expand All @@ -17,9 +17,9 @@ COPY Gopkg.toml Gopkg.lock ./
COPY . ./

# Use the default go proxy
ARG GO_PROXY=https://proxy.golang.org
ARG GO_PROXY=https://goproxy.io
ENV GOPROXY=$GO_PROXY
RUN go mod tidy
RUN go mod tidy -go=1.16 && go mod tidy -go=1.17
RUN CGO_ENABLED=0 GOOS=linux go build -mod=readonly -a -installsuffix nocgo -o /app .

FROM scratch
Expand Down
2 changes: 1 addition & 1 deletion walkthroughs/tls-with-acm/src/colorteller/deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@ ecr_login() {
}

# build and push
docker build -t $IMAGE $DIR --build-arg GO_PROXY=${GO_PROXY:-"https://proxy.golang.org"}
docker build -t $IMAGE $DIR --build-arg GO_PROXY=${GO_PROXY:-"https://goproxy.io"}
ecr_login
docker push $IMAGE