Conversation
github-actions
Bot
added
p2
beginning-contributor
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| await (0, archive_1.zipDirectory)(originalDir, zipFile, logger); | ||
| // unzip and verify that the resulting tree is the same | ||
| await exec(`unzip ${zipFile}`, { cwd: extractDir }); | ||
| await expect(exec(`diff -bur ${originalDir} ${extractDir}`)).resolves.toBeTruthy(); |
Check warning
Code scanning / CodeQL
Shell command built from environment values
| const zipFile = path.join(stagingDir, 'output.zip'); | ||
| await expect((0, archive_1.zipDirectory)(originalDir, zipFile, logger)).resolves.toBeUndefined(); | ||
| await expect(exec(`unzip ${zipFile}`, { cwd: extractDir })).resolves.toBeDefined(); | ||
| await expect(exec(`diff -bur ${originalDir} ${extractDir}`)).resolves.toBeDefined(); |
Check warning
Code scanning / CodeQL
Shell command built from environment values
rix0rrr
left a comment
rix0rrr
left a comment
There was a problem hiding this comment.
You have checked in new files that are build results, like .jsii and *.js and *.d.ts.
I think you might have had an old checkout of CDK lying around containing 2 packages that have gotten moved, packages/@aws-cdk/cloud-asembly-schema and packages/cdk-assets.
All those files need to be removed from this PR.
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Closing. Will resubmit with unwanted files removed from being accidentally added. |
|
Comments on closed issues and PRs are hard for our team to see. |
4 participants
Issue # (if applicable)
Closes #.
Reason for this change
By using Amazon owned s3 bucket physical names, we remove the possibility of documenting customer owned buckets in our examples.
Description of changes
Change physical S3 bucket names such as
my-bucketto Amazon owned ones such asamzn-s3-demo-bucket.Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license