Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: feat(cli): cdk rollback (#31407) #31657

Merged
merged 2 commits into from
Oct 5, 2024
Merged

revert: feat(cli): cdk rollback (#31407) #31657

merged 2 commits into from
Oct 5, 2024

Conversation

shikha372
Copy link
Contributor

@shikha372 shikha372 commented Oct 4, 2024

Issue # (if applicable)

Closes #31654.

Reason for this change

This reverts commit 0755561.

Description of changes

Changes introduced regression in amplify app for nested stacks, reverting it.

Description of how you validated changes

Validated with local build

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Oct 4, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team October 4, 2024 21:46
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 4, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Oct 4, 2024
@shikha372 shikha372 marked this pull request as ready for review October 4, 2024 22:17
@shikha372 shikha372 changed the title revert feat(cli): cdk rollback (#31407) revert feat(cli): cdk rollback (#31407) Oct 4, 2024
@shikha372 shikha372 changed the title revert feat(cli): cdk rollback (#31407) revert: feat(cli): cdk rollback (#31407) Oct 4, 2024
@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@shikha372 shikha372 added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Oct 5, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 5, 2024 01:50

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-cli-test-run This PR needs CLI tests run against it. label Oct 5, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3f49b8a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Oct 5, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 6e96234 into main Oct 5, 2024
19 of 20 checks passed
@mergify mergify bot deleted the shikagg_test_revert branch October 5, 2024 01:54
Copy link

github-actions bot commented Oct 5, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants